Test distance #368
Merged
Test distance #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkwagner
reviewed
Dec 13, 2022
tests/unit/test_distance.py
Outdated
|
|
||
| for index, ij in enumerate(ij_updown): | ||
| i, j = ij | ||
| assert (dupdown[:, index] == (configs2[:, j] - configs1[:, i])).all() |
There was a problem hiding this comment.
You should not use equality tests for floating point numbers. Please change to using (for example) np.isclose.
…tolerance, instead of just ==
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for distance.pairwise that checks if the ij_index output by distance.pairwise matches the corresponding entry in the distances output by distance.pairwise.