Started on an automated assembly step generator #75
Conversation
|
I know this is a draft, but I am going to push forward and merge as:
|
| assy.constrain("device@faces@<Z", "shelf@faces@<Z[-3]", "Plane") | ||
| assy.solve() | ||
|
|
||
| from cadquery.vis import show |
There was a problem hiding this comment.
Following PEP8 guidance Pylint gets upset if imports are not at the top of the file.
https://realpython.com/absolute-vs-relative-python-imports/#styling-of-import-statements
I'm going to leave this as a comment. We'll know to fix it later as PyLint is complaining
There was a problem hiding this comment.
This is just temporary during model development.
| the JSON file to be found. | ||
| """ | ||
|
|
||
| import json |
There was a problem hiding this comment.
See comment above for other import
There was a problem hiding this comment.
We can move them to the top. I like to have some imports only where/if they're used, but I know that's frowned upon by the Python community.
There was a problem hiding this comment.
Cheers. I tend to do what PyLint tells me unless I have a very good reason not to. I suppose the benefit of conventions is the code being structured in the way the python community expects.
This is an attempt to generate assembly step CAD models/assemblies using the device ID from devices.json. The code generates a placeholder device based on the dimensions in the database, generates the matching shelf, then attempts to put them together.
There is still missing data in the database to make this fully automated. For instance, where are the mounting hole locations in the hardware, if there are any? There needs to be some way to know if there are screws involved, and if so, where they go.