Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing #1

Open
Walkman100 opened this issue Jan 15, 2016 · 2 comments
Open

Signing #1

Walkman100 opened this issue Jan 15, 2016 · 2 comments
Assignees
@Walkman100
Labels
bug enhancement

Comments

@Walkman100
Copy link
Owner

Currently, the signing process signs the portable executable and the installer after the installer is generated, which means that the executable installed from the signed installer isn't signed.

Fixing this will require another signing section before the installer is generated.
@Walkman100 Walkman100 added the bug label Jan 15, 2016
@Walkman100 Walkman100 self-assigned this Jan 15, 2016
@Walkman100
Copy link
Owner Author

Walkman100 commented Feb 20, 2016 •
edited
Loading

This has been fixed so that currently the main program executable is signed, packaged into the installer then the installer is signed. However I have found something else that needs to be signed - the uninstaller. This is generated by NSIS on install time, but I remember reading in the NSIS documentation a way to generate the uninstaller on compile time so that it can be signed.

@Walkman100 Walkman100 reopened this Feb 20, 2016
@Walkman100
Copy link
Owner Author

http://nsis.sourceforge.net/Signing_an_Uninstaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Walkman100 Walkman100

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Walkman100