-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Switch HTTP client library from Apache HttpClient 4.x
to Apache HttpClient 5.x
(or okhttp
/ etc...)
#44
Comments
Feel free to do PR |
Is there a major benefit to doing this? Is the current version causing any problems? |
In addition, |
This need very great knowledge of changes between 4x and 5x. |
I did take a look at this there are two things worth noting:
I haven't been able to scope or examine the changes further. I think at this point the value should be questioned again since it's a major change for not just the library itself, but everyone that depends on it 🙂 |
Agree, I think it can cause a lot of breaking changes. Pros:
Cons:
|
I skimmed some of the issues. I can't tell how much of the issue is from user provided misconfiguration vs the library is not cleaning up after itself. I think I would personally make the goal to make the library harder to misconfigure (and fix any obvious bugs within it like not closing connections that should be closed). Those can be treated separately. Perhaps instead of exposing implementation to specific HttpBuilders for example, expose a number of tunable properties. The max number of connections, the max time to hold a connection open, etc. Maybe there's ways to improve specific issues people are having before a wholesale library change? |
Apache HttpClient 5.x
andokhttp
(orktor
) supportHTTP/2
(and asynchronous HTTP requests).Switching to these libraries is expected to enable more efficient HTTP requests.
Migrate issue from sedmelluq/lavaplayer#652
The text was updated successfully, but these errors were encountered: