Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use update-keys and update-vals from Clojure 1.11.1 #20

Merged
merged 2 commits into from
May 24, 2022
Merged

Use update-keys and update-vals from Clojure 1.11.1 #20

merged 2 commits into from
May 24, 2022

Conversation

fancygits
Copy link
Contributor

@fancygits fancygits commented May 17, 2022 •
edited

Proposed Changes

This fixes Issue #19.

  • Updates: Update Clojure to 1.11.1. Use new core functions in place of existing update-keys and update-vals.
  • Deletions: Unneeded tests

Pre-merge Checklist

  • Write + run tests
  • Update CHANGELOG and increment version
  • Update README and relevant documentation

@nnichols nnichols self-requested a review May 18, 2022 16:10
@nnichols nnichols mentioned this pull request May 18, 2022
Closed
@nnichols nnichols merged commit 6abd9fe into Wall-Brew-Co:master May 24, 2022
@nnichols
Copy link
Member

Thanks, Luke! Feel free to post this to the announcements channel on Clojurians!

nnichols added a commit that referenced this pull request Jul 6, 2022
@nnichols
Revert "Use update-keys and update-vals from Clojure 1.11.1 (#20)"
18d29ec 
This reverts commit 6abd9fe.
nnichols added a commit that referenced this pull request Jul 9, 2022
@nnichols
Fix Pre-clojure 1.11 compatibility (#25)
4bee6d9 
* Revert "Use `update-keys` and `update-vals` from Clojure 1.11.1 (#20)"

This reverts commit 6abd9fe.

* Fix pre 1.11 clojure compatability

* Use experimental linter

* Re:Add version info

* Fix linter version

* Add one linting error

* Bump action version

* regression test

* Bump linter

* Bump linter

* bump linter

* Bump linter

* Simplify

* Fix lint issue

* Minor linter test

* Version bump

* Tag functions with metadata, clean up tests

* [Format] Auto-formatting

* Fix typo

Co-authored-by: nnichols <nnichols@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnichols nnichols Awaiting requested review from nnichols

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fancygits @nnichols