Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC 5 requirement is out of date #1643

Closed
SeanTAllen opened this issue Oct 16, 2017 · 1 comment
Closed

GCC 5 requirement is out of date #1643

SeanTAllen opened this issue Oct 16, 2017 · 1 comment
Assignees
@SeanTAllen
Labels
documentation user-experience-improvement

Comments

@SeanTAllen
Copy link
Contributor

I believe that trusty's standard gcc 4 should be fine, rather than gcc 5. We should test with trusty and xenial to see if the "use gcc 5" is a requirement or if that can be relaxed for various linuxes.

Testing would involve doing an install leaving Trusty's standard gcc 4.x and then making sure all our python/examples work (probably just verify machida builds and a single example works would be fine).
@SeanTAllen SeanTAllen changed the title GCC 5 requirement might be out of date GCC 5 requirement is out of date Jan 8, 2018
@SeanTAllen
Copy link
Contributor Author

This is indeed out of date. We need at least 4.7.

The Go docs were written later and reflect what is correct.

SeanTAllen added a commit that referenced this issue Jan 8, 2018
@SeanTAllen
Update gcc requirements needed to build Machida
ba004a1 
When we first wrote the instructions, Pony's atomics support required
GCC 5 or higher. That is no longer true. GCC 4.7 or higher will work.

Closes #1643
@SeanTAllen SeanTAllen self-assigned this Jan 8, 2018
SeanTAllen added a commit that referenced this issue Jan 8, 2018
@SeanTAllen
Update gcc requirements needed to build Machida
99d9e87 
When we first wrote the instructions, Pony's atomics support required
GCC 5 or higher. That is no longer true. GCC 4.7 or higher will work.

Closes #1643

[skip ci]
@SeanTAllen SeanTAllen mentioned this issue Jan 8, 2018
Merged
aturley pushed a commit that referenced this issue Jan 9, 2018
@SeanTAllen @aturley
Update gcc requirements needed to build Machida
c36b841 
When we first wrote the instructions, Pony's atomics support required
GCC 5 or higher. That is no longer true. GCC 4.7 or higher will work.

Closes #1643

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanTAllen SeanTAllen

Labels
documentation user-experience-improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeanTAllen