Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualEnv documentation could lead some folks to thinking the example didn't work #2128

Closed
SeanTAllen opened this issue Mar 23, 2018 · 0 comments
Closed

VirtualEnv documentation could lead some folks to thinking the example didn't work #2128

SeanTAllen opened this issue Mar 23, 2018 · 0 comments
Assignees
@cararemixed
Labels
book user-experience-improvement

Comments

@SeanTAllen
Copy link
Contributor

If you follow the instructions as is, you'll get an error about the TCPSink not existing. Having the user set up an entire environment with a sink might or might not make sense. If we decide to not have them create a sink (reasonable given that its out of scope for virtualenv), we should let them know that the "TCPSink connection failed" error they would get running the machida command is expected and explain why.

screenshot 2018-03-23 10 53 22
@cararemixed cararemixed self-assigned this Mar 23, 2018
@cararemixed cararemixed mentioned this issue Mar 23, 2018
Merged
cararemixed pushed a commit that referenced this issue Mar 23, 2018
Clarify the setup with virtualenv and machida
bbd3117 
We still need to run a source and sink. Users may be confused
by errors if they have already missed that step.

closes #2128
nisanharamati pushed a commit that referenced this issue Mar 23, 2018
@nisanharamati
Clarify the setup with virtualenv and machida (#2131)
1c8519d 
We still need to run a source and sink. Users may be confused
by errors if they have already missed that step.

closes #2128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cararemixed cararemixed

Labels
book user-experience-improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cararemixed @SeanTAllen