Clarify the setup with virtualenv and machida #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A first pass on #2128. |
|
@strmpnk this looks good to me. Did you want both me and @aturley to review, or is one approval enough? |
We still need to run a source and sink. Users may be confused by errors if they have already missed that step. closes #2128
cararemixed
force-pushed
the
improve-virtualenv-docs-2128
branch
from
8cc1490
to
bbd3117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some prose after. I could copy what we have in other tutorials and just have the sink setup first followed by machida and then the source data ... but this is not for a specific example so it's unclear if we should document the entire setup (we can't assume much about the pipeline).