Bugfixes from omnibus 2 PR #3034 for connector sink #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures of the |
slfritchie
force-pushed
the
connector-sink-fixes
branch
from
a2a1ff7
to
55db7c6
Compare
slfritchie
force-pushed
the
connector-sink-fixes
branch
from
55db7c6
to
0b05289
Compare
|
I've rebased this PR onto today's |
|
Chat with John: Scott will update the base of this PR after merging several outstanding PRs. Some/all autoscale changes made here may no longer be necessary. |
This was referenced Nov 5, 2019
jtfmumm
reviewed
Nov 8, 2019
jtfmumm
reviewed
Nov 8, 2019
jtfmumm
reviewed
Nov 8, 2019
* Add debug diagnostics * Fix sink phase errors at early startup/InitSinkPhase * Fix sink phase errors with autoscale barrier processing * Add 2PC WorkersLeft message sending * Add _phase.early_prepare_for_rollback() * be rollback(): Send 2PC commands only if connected & 2PC intro done * Remove use of Pony runtime backpressure by sink when throttled * Add WorkerLeftMsg unit tests
Fixes #3015 Verified by using `./master-crasher.sh 1 crash-sink`, let the sink crash and restart a couple of times, then verify in /tmp/sender.out that there are new "acked Stream" messages where "is_open=True" and the "point_of_ref" value continues to increase.
slfritchie
force-pushed
the
connector-sink-fixes
branch
from
abdb45f
to
d0f9c92
Compare
* Move check for calling checkpoint_complete() * Avoid matching directly on the sink phase. * Add new class EarlySinkPhase to work around a chicken-and-the-egg problem caused by needing a valid Sink phase and not yet having a fully-initialized `Sink` object to pass to the constructor of the phase.
slfritchie
force-pushed
the
connector-sink-fixes
branch
from
d0f9c92
to
0aba6c0
Compare
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From omnibus 2 PR #3034.
Merge after PR #3039.