Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
aloc_sink
code into pieces that implement sink protocol & internal logic separately from what's necessary to manage the sink's persistent state. Code that implements the former is not refactored and thus remains ugly. However, it's our sink protocol reference implementation, and it works. If/when we want to refactor it, we've got a solid baseline.Reviewers should focus on the latter: managing the sink's persistent state. This refactoring is in advance of anticipated work that will send
aloc_sink
output to Kafka instead of the local file system. The API for theTwoPC_Output
base class may not be perfect for the Kafka case, but @JONBRWN and I believe it's probably good enough for now. Suggestions for better Python style are appreciated.