Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

feat: Cloudflare provider #4

Merged
merged 1 commit into from Jun 29, 2022
Merged

feat: Cloudflare provider #4

merged 1 commit into from Jun 29, 2022

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Jun 29, 2022

Changes

  • Adds Cloudflare provider

Changes Tested

Couldn't test as blocked by #3

  • Ran terraform -chdir=terraform apply -var-file="vars/dev.tfvars" locally

@HarryET HarryET added enhancement New feature or request ops Terraform labels Jun 29, 2022
@HarryET HarryET requested a review from a team June 29, 2022 16:11
@HarryET HarryET self-assigned this Jun 29, 2022
@HarryET HarryET requested review from bazaah and sbc64 and removed request for a team June 29, 2022 16:11
@arein
Copy link
Member

arein commented Jun 29, 2022

Not clear from PR context why this is needed. Approving under the condition that you provide PR details that explain

@@ -0,0 +1,2 @@
CLOUDFLARE_EMAIL=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear why this is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked like it was required and was provided to me by @sbc64 so I have included it here but happy to remove in a future PR should it turn out it is not in fact needed. I just can't test as I don't have dev creds and this branch doesn't have the fix from #3

@HarryET HarryET merged commit fc2f26f into main Jun 29, 2022
@HarryET HarryET deleted the harry/feat/cloudflare-setup branch June 29, 2022 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request ops Terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants