Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update to latest version of checkout action #1417

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ci: update to latest version of checkout action #1417

wants to merge 2 commits into from

Conversation

michaeltchuang
Copy link
Contributor

Summary

  • Upgrade checkout action to v4 (v3 is deprecated)

Testing Plan

  • Check Node.js 16 warning messages go away after next assemble job run

@michaeltchuang
Copy link
Contributor Author

michaeltchuang commented Jun 7, 2024 •
edited
Loading

@jakubuid - On forked repos, the secrets (e.g. secrets.SECRET_PROPERTIES) aren't getting passed in CI runs so tests fail. I think you will need to change the action trigger from pull request to pull_request_target if you want to accept forked open source PRs

something to be aware of with pull_request_target - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

or you can push my PR branch to origin repo and see if tests pass (if you rather not make this trigger change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaeltchuang