feat: add Client::certificate_parts() method #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a method that was missed during the inital PR merge. It allows the Client to be built using an imported set of PEM components.
jrconlin
added a commit
to mozilla-services/autopush-rs
that referenced
this pull request
May 26, 2023
This switches to our updated, but semi-vendored a2 release, while we wait for WalletConnect/a2#72 to land. This should also clear the warning about the included `nom` library.
HarryET
suggested changes
Jun 2, 2023
HarryET
approved these changes
Jun 4, 2023
|
No worries, and no rush! Thank you, again, for taking on this library. Hopefully, that should be the last of the post merge updates. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a method that was missed during the initial PR merge. It allows the Client to be built using an imported set of PEM components.
How Has This Been Tested?
A unit test has been added with test cert / key values
Due Dilligence