feat: add ws proxy functionality #115
Conversation
Rakowskiii
requested review from
a team and
xDarksome
and removed request for
a team and
xDarksome
| } | ||
|
|
||
| impl IntoResponse for RpcError { | ||
| fn into_response(self) -> axum::response::Response { | ||
| error!("{:?}", self); |
There was a problem hiding this comment.
Is this a recommended way to log errors in axum? I tend to consider logging inside conversion functions to be a bad practice.
Is there some other place we could tap_err or something?
There was a problem hiding this comment.
I don't think this is recommended way.
My thought process behind this was: tapping in each place separately may lead to some uncovered spots in the future. Logging it here take off the responsibility from future contributors, as they don't need to keep remembering about each and every error they return.
There was a problem hiding this comment.
We should be able to do logging via some middleware abstraction of axum, like layer or something, but I don't have a better solution rn. So LGTM for now
There was a problem hiding this comment.
I'll drop this as issue, thanks
|
Also, fix the unused code warning in |
| } | ||
|
|
||
| #[async_trait] | ||
| pub trait RpcWsProvider: Send + Sync + Provider { |
There was a problem hiding this comment.
Nitpick: Send + Sync + 'static are conventionally being written at the end
| } | ||
|
|
||
| impl IntoResponse for RpcError { | ||
| fn into_response(self) -> axum::response::Response { | ||
| error!("{:?}", self); |
There was a problem hiding this comment.
We should be able to do logging via some middleware abstraction of axum, like layer or something, but I don't have a better solution rn. So LGTM for now
Description
Adding handler for websocket proxying
/wsCurrently only supporting infura, as pokt doesn't seem to support websockets.
Zksync is deprecating ws https://docs.zksync.io/api/sdk/js/providers/#create-websocket-provider-it-is-deprecated-and-will-be-removed-soon
Resolves #87
How Has This Been Tested?
Tests ran for each connection.
Due Diligence