fix: retrieve client IP from X-Forwarded-For header
#428
Conversation
There was a problem hiding this comment.
I think we use a library to abstract this away in Verify API or somewhere else - maybe @xDarksome or @chris13524 know?
But as a hotfix this shouldn't wait for that - can improve later
|
You mean this? https://github.com/WalletConnect/verify-server/blob/main/src/http_server/mod.rs#L26 |
| .get("X-Forwarded-For") | ||
| .and_then(|header| header.to_str().ok()) | ||
| .and_then(|header| header.split(',').next()) | ||
| .and_then(|client_ip| client_ip.trim().parse::<IpAddr>().ok()) |
There was a problem hiding this comment.
It looks scary not to handle any errors here. Malformed X-Forwarded-For can lead to 500 errors without any debug information.
There was a problem hiding this comment.
won't the and_then chain default to an Error and ultimately to a None if anything goes wrong?
Yeah, I added it but
|
It's a hotfix and I think it should have the same end result. But we can overhaul this after. |
Description
Since the migration moved the service behind an ALB, we cannot retrieve the client IP directly for geo-location.
This leverages the
X-Forwarded-Forheader injected by the LB instead.How Has This Been Tested?
Unit tests
Due Diligence