This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
feat: project validation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
reviewed
Jul 18, 2023
|
Let's NOT merge this untill we are sure all other SDKs are sending |
|
Also - this supports redis cache, but will add terraform and env vars in separate PR |
chris13524
approved these changes
Jul 21, 2023
Comment on lines
+16
to
+19
| pub enum Addr<'a> { | ||
| Combined(&'a str), | ||
| Separate { read: &'a str, write: &'a str }, | ||
| } |
There was a problem hiding this comment.
This feels like an unnecessary abstraction. Why do we need to differentiate between Combined and Separate? Why not pass-through auth_redis_addr_read|write to Redis::new()?
There was a problem hiding this comment.
Tbh this is just copied from RPC proxy, but if you feel it's unnecessary we can just get rid of it
There was a problem hiding this comment.
It's fine to leave as-is for now
HarryET
approved these changes
Jul 22, 2023
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding project secret validaiton to all endpoints that should be only usable by authenticated projects.
Resolves #98
How Has This Been Tested?
Due Diligence