feat: metrics #103
Merged
feat: metrics #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
approved these changes
Feb 15, 2023
Comment on lines
+1
to
+11
| #[macro_export] | ||
| macro_rules! increment_counter { | ||
| ($state:ident.$property:ident, $metric:ident) => {{ | ||
| use {opentelemetry::Context, tracing::debug}; | ||
|
|
||
| if let Some(metrics) = &$state.$property { | ||
| metrics.$metric.add(&Context::current(), 1, &[]); | ||
| debug!("incremented `{}` counter", stringify!($metric)); | ||
| } | ||
| }}; | ||
| } |
There was a problem hiding this comment.
thought: I was going to suggest using a function instead of a macro here, but looks like the problem with that is not being able to read the metric name from the metric object itself (for the debug!()). Interesting limitation of the library.
| ($state:ident.$property:ident, $metric:ident) => {{ | ||
| use {opentelemetry::Context, tracing::debug}; | ||
|
|
||
| if let Some(metrics) = &$state.$property { |
There was a problem hiding this comment.
Looks like this macro only supports a first argument in the form ident.ident? What if I wanted to pass a more deeply-nested identifier such as ident.ident.ident? Would using $metrics:expr as the first macro parameter make this more generalized?
There was a problem hiding this comment.
It can be added but right now I know that it will only be one deep -> can be looked at later though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more metrics as well as a macro for easily incrementing a counter on the
state.metricsproperty when they are enabled.How Has This Been Tested?
N/a, will test in grafana after deployed to prod and then PR the new dashboard back
Due Diligence