Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all data provided #164

Merged
merged 4 commits into from
Jul 20, 2023
Merged

fix: ensure all data provided #164

merged 4 commits into from
Jul 20, 2023

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Jul 20, 2023

Description

Ensures all analytics for push_messages always have analytics

Resolves #163

How Has This Been Tested?

Locally with debugger

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@HarryET HarryET self-assigned this Jul 20, 2023
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there some tests missing?

In the Relay the functional tests confirm that metrics work

@HarryET
Copy link
Contributor Author

HarryET commented Jul 20, 2023

Are there some tests missing?

In the Relay the functional tests confirm that metrics work

There are no tests atm for Echo analytics, I'll make an issue to investigate how the relay does it and get them here!

@HarryET HarryET merged commit 6dc5949 into main Jul 20, 2023
4 checks passed
@chris13524 chris13524 deleted the fix/missing-analytics-data branch October 23, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: issue with analytics new fields
2 participants