feat: fcm verification #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
arein
approved these changes
Aug 1, 2023
I'm investigating maybe a cron job that checks once a day for invalid api keys and then suspends the projects, this would then also catch projects which invalidate their api key after submitting it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FCM API Keys are not validated to ensure they work with the FCM Api before the tenant is saved.
Resolves # (issue)
How Has This Been Tested?
Adding interation tests to ensure it fails on invalid API Keys, and passes on valid ones. Requires valid FCM API Key in the env vars
Due Diligence