Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump update_rust_version to 2.1.5 #237

Merged
merged 1 commit into from
Oct 5, 2023
Merged

ci: bump update_rust_version to 2.1.5 #237

merged 1 commit into from
Oct 5, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 5, 2023 •
edited
Loading

Description

Bumping update-rust-version CI action script to 2.1.5 because of Cargo.lock issue.

Resolves #238

How Has This Been Tested?

Test plan in WalletConnect/actions#20

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother requested a review from xav October 5, 2023 12:09
@geekbrother geekbrother self-assigned this Oct 5, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 5, 2023
@geekbrother geekbrother changed the title ci: bump update_rust_version ci: bump update_rust_version to 2.1.5 Oct 5, 2023
@geekbrother geekbrother marked this pull request as ready for review October 5, 2023 12:12
chris13524
chris13524 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekbrother geekbrother merged commit 066bd18 into main Oct 5, 2023
5 of 8 checks passed
@chris13524 chris13524 deleted the max/ci/bump_actions_version branch October 5, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@xav xav Awaiting requested review from xav

Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: bump update_rust_version to 2.1.5
3 participants
@geekbrother @chris13524 @arein