Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding logs to apns update #245

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds error logging for the apns update handler on certificate validation.

Resolves #244

How Has This Been Tested?

Doesn't require additional testing then CI workflow.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 13, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 13, 2023
@geekbrother geekbrother marked this pull request as ready for review October 13, 2023 12:40
@geekbrother geekbrother merged commit 80e3bf5 into main Oct 13, 2023
4 checks passed
@chris13524 chris13524 deleted the max/fix/add_logs_to_apns branch October 13, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: APNS certificate validation errors
3 participants