Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing apns keys encoding #246

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: fixing apns keys encoding #246

merged 2 commits into from
Oct 17, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 15, 2023

Description

To fix the multi-tenant apns update bug (where apns key is always wrong), the following changes and fixes are made:

Commit 163155f fix:

Commit 917c36a test:

  • Functional unit test tenant_update_apns_valid_token was created to cover testing apns update using the reqwest post request with the multipart form with valid apns p8 key from the environment variable,
  • Adding required CI variables passing to run tenant_update_apns_valid_token unit test with valid apns p8 key from GitHub secrets.

Resolves #244

How Has This Been Tested?

It was tested by the CI unit test tenant_update_apns_valid_token from this PR.
The expected behavior is passing the tenant_update_apns_valid_token from the CI gate.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 15, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 15, 2023
@geekbrother geekbrother marked this pull request as ready for review October 15, 2023 22:01
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tests are updated and I'm sure you thought through the migration path

Deferring to @chris13524

@geekbrother
Copy link
Contributor Author

geekbrother commented Oct 16, 2023

lgtm - tests are updated and I'm sure you thought through the migration path

API has not changed, so it doesn't require a migration from the current state except adding of few additional secrets (already done).

@flypaper0
Copy link

👏

@geekbrother geekbrother merged commit 2e6a9fe into main Oct 17, 2023
4 checks passed
@chris13524 chris13524 deleted the max/fix/apns_not_updated branch October 17, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: APNS certificate validation errors
4 participants