Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix the multi-tenant apns update bug (where apns key is always wrong), the following changes and fixes are made:
Commit 163155f fix:
Invalid Multipart Body
when the password was not provided,BufReader
withCursor
as we don't need to create a buffer and can use just a cursor.Commit 917c36a test:
tenant_update_apns_valid_token
was created to cover testing apns update using thereqwest
post request with the multipart form with valid apns p8 key from the environment variable,tenant_update_apns_valid_token
unit test with valid apns p8 key from GitHub secrets.Resolves #244
How Has This Been Tested?
It was tested by the CI unit test
tenant_update_apns_valid_token
from this PR.The expected behavior is passing the
tenant_update_apns_valid_token
from the CI gate.Due Diligence