Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing and enabling ignored tests #263

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: fixing and enabling ignored tests #263

merged 1 commit into from
Oct 24, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 23, 2023 •
edited
Loading

Description

Fixing for running and removing ignore for the following tests:

  • Updating fcm with the valid API key,
  • Register, get, and delete new tenants.

Resolves #264

How Has This Been Tested?

Tests are run by the CI unit tests workflow and passing it:

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother added the area-tests Testing label Oct 23, 2023
@geekbrother geekbrother self-assigned this Oct 23, 2023
@geekbrother geekbrother changed the title fix: enabling ignored tests fix: fixing and enabling ignored tests Oct 23, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 23, 2023
@geekbrother geekbrother marked this pull request as ready for review October 23, 2023 11:09
arein
arein approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@geekbrother geekbrother merged commit 7bf555a into main Oct 24, 2023
12 of 14 checks passed
@geekbrother geekbrother deleted the max/fix/enable_ignored_tests branch October 24, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

@chris13524 chris13524 chris13524 approved these changes

Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project area-tests Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: enabling and fixing ignored tests
3 participants
@geekbrother @arein @chris13524