fix: idempotency per client #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
approved these changes
Nov 8, 2023
chris13524
force-pushed
the
fix/idempotency-per-client
branch
from
c917bdb
to
bee9cb5
Compare
chris13524
force-pushed
the
fix/idempotency-per-client
branch
from
3e9194d
to
886b530
Compare
chris13524
force-pushed
the
fix/idempotency-per-client
branch
3 times, most recently
from
086a609
to
0e23353
Compare
chris13524
force-pushed
the
fix/idempotency-per-client
branch
from
0e23353
to
e9d4fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If multiple clients are subscribed to the same topic and are registered to receive push notifications, this won't work because the idempotency logic is designed to prevent the same message ID from being notified multiple times.
This behavior was actually flakey due to the idempotency logic itself not being robust against race conditions, but this is a separate issue.
Context: https://walletconnect.slack.com/archives/C044SKFKELR/p1699446818332569?thread_ts=1699442986.858579&cid=C044SKFKELR
Resolves #273
How Has This Been Tested?
Due Diligence