Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix all warnings #276

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: fix all warnings #276

merged 1 commit into from
Nov 13, 2023

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Nov 13, 2023 •
edited
Loading

Description

  • Change clippy to deny all warnings. Denying clippy::all doesn't deny normal compiler warnings, and clippy::all is already warning by default, so denying warnings includes everything.
  • Also add 2 more clippy invocations with different sets of feature flags to detect all the code paths that were previously not tested by clippy.
  • Fix all the warnings.
  • Change env!() to std::env::var() to allow running clippy without these env vars set. Not sure why these were being compiled into the binary.

How Has This Been Tested?

CI tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Nov 13, 2023
@arein arein added the accepted The issue has been accepted into the project label Nov 13, 2023
@chris13524 chris13524 merged commit f3c5dd6 into main Nov 13, 2023
10 checks passed
@chris13524 chris13524 deleted the chore/fix-clippy-warnings branch November 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

@xav xav Awaiting requested review from xav

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris13524 @geekbrother @arein