fix: tenants update on conflict handling #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
changed the title
chris13524
reviewed
Jan 31, 2024
| @@ -314,7 +318,7 @@ impl TenantStore for PgPool { | |||
| #[instrument(skip(self))] | |||
| async fn update_tenant(&self, id: &str, params: TenantUpdateParams) -> Result<Tenant> { | |||
| let res = sqlx::query_as::<sqlx::postgres::Postgres, Tenant>( | |||
| "UPDATE public.tenants SET id = $2 WHERE id = $1 RETURNING *;", | |||
| "UPDATE public.tenants SET id = $2, updated_at = NOW() WHERE id = $1 RETURNING *;", | |||
There was a problem hiding this comment.
What is the purpose even of this function? It looks like this is never called anyway. Should just remove as id shouldn't be updated.
There was a problem hiding this comment.
It was added a long ago, probably the author expect to use it somehow. I'll remove this rudiment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have rare errors where the client tries to create tenants with the same
idthat causes the following errors:This PR adds:
ON CONFLICTwhile creating the new tenant.updated_atfield on any updates of the record.How Has This Been Tested?
Functional tests for multitenant.
Due Diligence