Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separate staging and prod JWT secrets #318

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: separate staging and prod JWT secrets #318

merged 1 commit into from
Apr 22, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Apr 22, 2024 •
edited
Loading

Description

Separate JWT_SECRET for staging and prod environments. Slack conversation

  • STAGING_JWT_SECRET secret crated in GitHub
  • PROD_JWT_SECRET secret crated in GitHub

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Apr 22, 2024
@arein arein added the accepted The issue has been accepted into the project label Apr 22, 2024
@chris13524 chris13524 requested review from geekbrother and removed request for Cali93 April 22, 2024 20:41
@chris13524 chris13524 merged commit 30b172e into main Apr 22, 2024
4 checks passed
@chris13524 chris13524 deleted the fix/separate-staging-prod-jwt-secrets branch April 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

@nopestack nopestack Awaiting requested review from nopestack

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris13524 @geekbrother @arein