fix: applying rate limiting middleware to all except push endpoints #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
fix/rate_limit_push_exception
branch
from
881b9ee
to
b3ebb48
Compare
geekbrother
force-pushed
the
fix/rate_limit_push_exception
branch
from
b3ebb48
to
df18a14
Compare
geekbrother
commented
May 16, 2024
| .route( | ||
| "/:tenant_id/clients/:id", | ||
| post(handlers::push_message::handler), | ||
| ) | ||
| .layer(global_middleware); | ||
|
|
||
| let app = if let Some(geoblock) = state_arc.geoblock.clone() { |
There was a problem hiding this comment.
Removing this part as we are applying the geoblock and state later and not depending on the multitenant feature. This is a fix to double applying the geoblock and state.
geekbrother
force-pushed
the
fix/rate_limit_push_exception
branch
from
df18a14
to
e3122ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applying the rate-limiting middleware to all endpoints except message push because it's used by the Relay and validated by the signature.
Also, this PR fixes the bug of double applying the
geoblockandwith statemiddlewares.How Has This Been Tested?
Due Diligence