-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Postgres query metrics #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show Plan
Action: |
3c2a73d
to
e4f2a5f
Compare
7251228
to
c088277
Compare
Show Plan
Action: |
c088277
to
dd7c541
Compare
Show Plan
Action: |
chris13524
commented
May 20, 2024
@@ -352,7 +368,7 @@ resource "grafana_dashboard" "at_a_glance" { | |||
"uid" : grafana_data_source.prometheus.uid | |||
}, | |||
"exemplar" : true, | |||
"expr" : "sum(rate(registered_clients{}[$__rate_interval]))", | |||
"expr" : "sum(rate(registered_clients_total{}[$__rate_interval]))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #334 this name has changed
![image](https://private-user-images.githubusercontent.com/1979423/332189645-07c60027-09ff-4391-b9c7-0c0bffaa94ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5NDg0ODgsIm5iZiI6MTcyMDk0ODE4OCwicGF0aCI6Ii8xOTc5NDIzLzMzMjE4OTY0NS0wN2M2MDAyNy0wOWZmLTQzOTEtYjljNy0wYzBiZmZhYTk0YWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTRUMDkwOTQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzUxMDA2ODA0MGMwOTExMTQzMTk2ZDZiM2ZiYjE4M2I0ZThhMjU5NDI5Y2M5NDFhZjc0ZTdmYjM5YWU2YTM1NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.DNJBU-djanpjTO6zSwWq-st6pR2WY4q02CaROqN5JRs)
Show Plan
Action: |
nopestack
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds metrics for Postgres queries so we can attempt to identify if create_client is slow or not, potentially leading to draining Postgres connection pool.
Depends on #335
How Has This Been Tested?
Not tested
Due Diligence