fix: improve create client performance #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nopestack
approved these changes
May 21, 2024
It was the culmination of multiple iterations of new queries not susceptible to concurrency errors. I think we went with DELETE because it was easier than handling all of the insert or update cases (of which this PR now implements directly). |
geekbrother
approved these changes
May 21, 2024
There was a problem hiding this comment.
lgtm, thanks! One comment: did we miss the transaction between select and updates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we are deleting and re-inserting the record, and it turns out the delete operation is quite expensive compared to the insert. Refactoring the queries to only do the operations necessary: insert or update while still locking the record for update.
Slack conversation
How Has This Been Tested?
Not tested
Due Diligence