Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle FCM v1 token unregistration & forbidden & Apns(TopicDisallowed) #342

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix: handle FCM v1 token unregistration & forbidden & Apns(TopicDisallowed) #342

merged 3 commits into from
Jun 5, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jun 4, 2024 •
edited
Loading

Description

Handle more error codes

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Jun 4, 2024
@arein arein added the accepted The issue has been accepted into the project label Jun 4, 2024
@chris13524 chris13524 changed the title fix: handle FCM v1 token unregistration fix: handle FCM v1 token unregistration & forbidden Jun 4, 2024
@chris13524 chris13524 changed the title fix: handle FCM v1 token unregistration & forbidden fix: handle FCM v1 token unregistration & forbidden & Apns(TopicDisallowed) Jun 4, 2024
geekbrother
geekbrother approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chris13524 chris13524 merged commit 2f0c70a into main Jun 5, 2024
6 checks passed
@chris13524 chris13524 deleted the fix/handle-fcmv1-token-unregistration branch June 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

@nopestack nopestack Awaiting requested review from nopestack

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris13524 @geekbrother @arein