Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apns): proper handling of the wrong CA in APNS certificate #343

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds an additional catching and handling of the received fatal alert: UnknownCA APNS client error.
The same action was added to disable the tenant in case of the unknown CA certificate error as for the expired APNS certificate since the certificate can't be used to send the push notification until it is updated.

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jun 20, 2024
@arein arein added the accepted The issue has been accepted into the project label Jun 20, 2024
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@geekbrother geekbrother merged commit fc38254 into main Jun 21, 2024
6 checks passed
@geekbrother geekbrother deleted the fix/apns_wrong_ca branch June 21, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants