Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for web3inbox #365
Add spec for web3inbox #365
Changes from all commits
e59834e
17c2a55
4180674
a1e12eb
29fefc2
497e124
64f08e1
179e57c
696d5fd
2526ab7
bbbb1e3
b79ca6c
2929136
2ee7c0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you call it Web3InboxSDKChatFacade, to me it looks exactly like ChatClient?
do we even need to spec it here? correct me if I am wrong but it looks like a duplicate to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has the same methods, but not the same event listeners and as of now there's no guarantee it'll always be 1:1 with the chat client, as it may have more functionality moving forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call it client like we always do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels off to call it a client since it technically doesn't handle any relay communication on its own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no hight level API client does, they all use core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's not like
push
orchat
, I really don't think we can compareweb3inboxSDK
topush
andchat
. cc @pedrouidThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these SDKs are multiple clients so it wouldn't make sense to call it a client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chat and Push clients are dependent on CoreClient, which is responsible for handling networking. Is that the case here as well? If yes, we should inject CoreClient instead of projectId and relayUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W3I will manage
push
,chat
and thecore
they'll depend on. In the mobile case, the clients will be handled completely externally outsidew3i