Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Failing: we need PR status checks from Travis #4

Closed
pedrouid opened this issue Sep 1, 2018 · 2 comments
Closed

Build Failing: we need PR status checks from Travis #4

pedrouid opened this issue Sep 1, 2018 · 2 comments

Comments

@pedrouid
Copy link
Member

pedrouid commented Sep 1, 2018

Build is failing after merging PR #2, we should add status check requirements for PRs from Travis builds to ensure it works before merging
@jdkanani
Copy link
Contributor

jdkanani commented Sep 1, 2018

It's already there - https://travis-ci.org/WalletConnect/walletconnect-monorepo/builds/423311734

I will try to remove Travis cache and restart build.

@pedrouid
Copy link
Member Author

pedrouid commented Sep 1, 2018

My bad! I had to do it on the settings under Branch Protection

@pedrouid pedrouid closed this as completed Sep 1, 2018
pedrouid pushed a commit that referenced this issue Apr 28, 2021
# This is a combination of 4 commits.
3948c11 
# This is the 1st commit message:

Update dockerignore for slimmer build context

# This is the commit message #2:

Remove innefective node flat

# This is the commit message #3:

Re-add relay1

# This is the commit message #4:

Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdkanani @pedrouid