Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to receive signature from Gnosis Safe multisig app #4464

Closed
eugenPtr opened this issue Apr 19, 2024 · 11 comments
Closed

Failing to receive signature from Gnosis Safe multisig app #4464

eugenPtr opened this issue Apr 19, 2024 · 11 comments
Assignees
Labels
type: bug Something isn't working

Comments

@eugenPtr
Copy link

Describe the bug

I am building an app that needs to be able to receive messages signed with Gnosis Safe
While this worked well with Metamask, I am getting a Request expired. Please try again. error when I do it through Gnosis Safe. I have tested this on Sepolia, signing the message right away and having the tx confirmed by Safe in under 1 minute. The app keeps waiting to receive the signature from WC until the request times out.

To fetch the signature I am using signMessageAsync from wagmi's useSignMessage hook.

SDK Version (if relevant)

  • @web3modal/wagmi - 4.1.6
  • wagmi - 2.5.19

To Reproduce
Steps to reproduce the behavior:

  1. Login through WC with Safe Wallet on Desktop
  2. User clicks a button requesting them to Sign a message
  3. User is redirected to the Safe wallet page in the browser
  4. User signs tx which gets confirmed less than a minute after
  5. User then goes to the app when a loader is spinning until the signature is received
  6. After a few minutes the browser console logs the error: Request expired. Please try again

Expected behavior
The signature is received after a while, before timing out

@eugenPtr eugenPtr added the type: bug Something isn't working label Apr 19, 2024
Copy link

linear bot commented Apr 19, 2024

@ganchoradkov
Copy link
Member

hey @eugenPtr session requests have default expiry of 5 minutes. Is it taking longer for you to sign?

@eugenPtr
Copy link
Author

hey @ganchoradkov, thanks for picking this up. It's taking under a minute to sign and see the transaction confirmed.

@eugenPtr
Copy link
Author

@ganchoradkov any idea what the issue could be here?

@glitch-txs
Copy link
Member

Please update Wagmi and Web3Modal packages to latest. Feel free to repoen if the issue persists.

@ryanberckmans
Copy link

I'm experiencing this same issue where useSignMessage, WalletConnect, and Gnosis Safe doesn't detect the Safe contract's emitted SignMsg event and hangs in pending until timing out.

I'm using wagmi latest (2.10.9), @walletconnect/ethereum-provider latest (2.13.3), and @walletconnect/modal latest (2.6.2).

@Starfeathers71
Copy link

Not one of the wallets and connectors work

@glitch-txs glitch-txs reopened this Jul 9, 2024
@ryanberckmans
Copy link

I'm experiencing this same issue where useSignMessage, WalletConnect, and Gnosis Safe doesn't detect the Safe contract's emitted SignMsg event and hangs in pending until timing out.

I'm using wagmi latest (2.10.9), @walletconnect/ethereum-provider latest (2.13.3), and @walletconnect/modal latest (2.6.2).

I ended up "solving" this by writing a wrapper library that polls for the creation of the eip-1271 hash via useReadContract in parallel with the useSignMessage. Then I abort the pending useSignMessage when the eip-1271 hash becomes available.

@eugenPtr
Copy link
Author

@ryanberckmans do you mind sharing the workaround?

@glitch-txs
Copy link
Member

I'm not able to repro in the latest: https://lab.web3modal.com/library/wagmi/

I'm able to sign a message with Safe succefully.

@glitch-txs glitch-txs closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@glitch-txs
Copy link
Member

please provider a MRE

@WalletConnect WalletConnect locked and limited conversation to collaborators Jul 11, 2024
@glitch-txs glitch-txs converted this issue into discussion #5175 Jul 11, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants