Decouple WebSocket transport from Core #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-monorepo into disable-exchange-key
…ct/walletconnect-monorepo into disable-exchange-key
pedrouid
requested review from
abstractpoint,
Dobrokhvalov,
grachyov,
jdkanani,
jinchung,
ligi,
rmeissner and
vikmeup
|
PS - I've added changes from the PR #104 to disable exchange key temporarily as it's also going to be refactored following the Proposal described on #105 |
…ct-monorepo into refactor-core
…etconnect-monorepo into refactor-core-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started a branch called
refactor-corein order to start refactoring a decoupling components from the massive core library file. Looking for feedback and suggestions to improve the refactor.The goal is to decouple WebSockets, EventEmitter, ExchangeKey, InternalEvent handlers, JSON-RPC handles, Subscribers, etc