Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #3918

Merged
merged 3 commits into from
Nov 14, 2023
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #3918

merged 3 commits into from
Nov 14, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 14, 2023

Description

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx aws-sdk-js-codemod@0.28.2 -t v2-to-v3 packages/sign-client/**/*.ts

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

N/A

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@trivikr trivikr marked this pull request as ready for review November 14, 2023 00:04
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for upgrading this @trivikr 🙏

Tagging @arein and @ganchoradkov as the folks most familiar with the touched code and the pipeline. Looks like a types-only kind of change though anyways 👍

Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR @trivikr 💯

@ganchoradkov ganchoradkov merged commit 2fce448 into WalletConnect:v2.0 Nov 14, 2023
5 of 10 checks passed
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 14, 2023 16:21
@ganchoradkov ganchoradkov mentioned this pull request Nov 15, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants