Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URI validation #3960

Merged
merged 6 commits into from
Nov 21, 2023
Merged

fix: URI validation #3960

merged 6 commits into from
Nov 21, 2023

Conversation

ganchoradkov
Copy link
Member

Description

Fixed a bug where when invalid URI is provided such as v1 uri, or any other that is missing relay-protocol was resulting in unhandled exception instead of returning the rejection

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Fixes/Resolves (Optional)

#3813

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

packages/core/src/controllers/pairing.ts Outdated Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit 1fce93e into v2.0 Nov 21, 2023
9 checks passed
@ganchoradkov ganchoradkov deleted the fix/uri-validation branch November 21, 2023 12:17
@ganchoradkov ganchoradkov mentioned this pull request Nov 29, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants