sendAsync method result response formatted

[kr-nikunj]

Creating a release? Please use the Release PR Template instead.

Description

fixed JSON RPC response in specific format, issue: #3984

return {
    id,
    jsonrpc: "2.0",
    result,
  };

Type of change

• Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Using manually testing of logs and and running the test file

Use this table template to show examples of your changes:

Before	After

Checklist

• I have performed a self-review of my own code
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[ganchoradkov]

.then((response) => callback(null, formatJsonRpcResult(id, response)))

Do we need to format the response here? Afaik all responses are already formatted as jsonRpcResult by the responding client

[kr-nikunj]

Yes, the client is not responding in a formatted manner

[kr-nikunj]

@ganchoradkov, Facing the same issue while running these test cases on the main branch, please check it

[ganchoradkov]

please make sure you run

• npm i in root to fetch new packages
• npm run reset to rebuild the monorepo
  for some reason the relay is rejecting your jwt and/or projectId

also your system's datetime as jwt is valid for 1 day so if you datetime is forward/back in time might cause it

[kr-nikunj]

Hey @ganchoradkov, I tried that also and ran it in a local file but it gave the same error. For passing the test case there might be a change in the workflow file of the repo where it is not getting environment variables correctly.

If possible can I DM you on Discord or any other platform to resolve this issue?

[ganchoradkov]

@GanchoRadkov on telegram

[kr-nikunj]

@ganchoradkov, can you please tell me where you set environment variables?

in workflow file:
https://github.com/WalletConnect/walletconnect-monorepo/actions/runs/7084385293/workflow?pr=3996

Because I run test cases locally and it's running properly. and facing issue here only.

[kr-nikunj]

In the universal provider's test file ( walletconnect-monorepo/providers/universal provider/test/shared/constant.ts), If I put my project ID and relay id directly, it passes all test cases. for getting the environment variable it failed test cases.

This is run while I define my project ID directly to a constant file

please check it @ganchoradkov

[ganchoradkov]

thanks for fixing @kr-nikunj 💯 🥇