fix: added extra condition in isBrowser function #4069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getNavigator
returns{"product": "ReactNative"}
, andgetDocument
returnsundefined
The origin of the issue is here:
walletconnect-monorepo/packages/utils/src/misc.ts
Lines 406 to 407 in 91af38e
because
localStorage.getItem
is executed in a RN environmentAnother option is to change the
isBrowser
condition to something that also covers react native, such asType of change
How has this been tested?
Tested locally in react native
Fixes/Resolves (Optional)
WalletConnect/web3modal-react-native#116
Checklist