Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unique watch label for each topic #4123

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: unique watch label for each topic #4123

merged 1 commit into from
Jan 11, 2024

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 11, 2024 •
edited

Description

To avoid unexpected behaviours when isSubscribed is called simultaneously multiple times, now unique subscribtion is used per topic

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

canary - 2.11.0-canary.0

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Jan 11, 2024
@ganchoradkov ganchoradkov marked this pull request as ready for review January 11, 2024 16:31
devceline
devceline approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devceline devceline mentioned this pull request Jan 11, 2024
Merged
@ganchoradkov ganchoradkov merged commit 57c73a0 into v2.0 Jan 11, 2024
13 checks passed
@ganchoradkov ganchoradkov deleted the fix/subscribe-watch-label branch January 11, 2024 19:56
@ganchoradkov ganchoradkov mentioned this pull request Jan 12, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devceline devceline devceline approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganchoradkov @devceline @arein