fix: synced expiries #4159
fix: synced expiries #4159
Conversation
ganchoradkov
changed the title
…connect-monorepo into fix/synced-expiries
This is for backwards compat I'm assuming? |
correct |
| @@ -156,6 +157,8 @@ export class Engine extends IEngine { | |||
|
|
|||
| const publicKey = await this.client.core.crypto.generateKeyPair(); | |||
|
|
|||
| const expiry = ENGINE_RPC_OPTS.wc_sessionPropose.req.ttl || FIVE_MINUTES; | |||
There was a problem hiding this comment.
ENGINE_RPC_OPTS.wc_sessionPropose.req.ttl is already a constant right, why do we need the || defaulting?
There was a problem hiding this comment.
it's type is actually number | undefined causing ts to complain
There was a problem hiding this comment.
might be better just updating it to explicit type number and not optional
| @@ -397,6 +398,16 @@ export class Pairing implements IPairing { | |||
| const { message } = getInternalError("MISSING_OR_INVALID", `pair() uri#symKey`); | |||
| throw new Error(message); | |||
| } | |||
| if (uri?.expiryTimestamp) { | |||
| const expiration = toMiliseconds(uri?.expiryTimestamp); | |||
| if (expiration < Date.now()) { | |||
There was a problem hiding this comment.
Probably strictly theoretical rather than realistic, but I think there's an edge case here where:
toMilisecondssimply adds zeroes to the end of seconds-basedexpirationDate.now()has non-zero values in the last 3 digits
Either way I think we can ignore because that only applies within the same second :)
|
@ganchoradkov it's not entirely clear how to apply this fix to override those five minutes. Any documentation on it? Thanks |
Description
Implemented synced expiries for session proposals and session requests. Synced expiries are defined by the sending peer and used by both sending & receiving peers. If no
expiryTimestampis received, default values are used.Additionally
Type of change
How has this been tested?
tests
dogfooding
WalletConnect/web-examples#432
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.