Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cloudwatch metrics tags #4172

Merged
merged 1 commit into from
Jan 26, 2024
Merged

feat: cloudwatch metrics tags #4172

merged 1 commit into from
Jan 26, 2024

Conversation

heilhead
Copy link
Contributor

@heilhead heilhead commented Jan 25, 2024

Creating a release? Please use the Release PR Template instead.

Description

This adds the Tag dimension to all metrics exported by the sign client canary. It's a requirement for the relay to be able to run multiple canaries with different configurations and be able to distinguish resulting metrics.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Untested.

Fixes/Resolves (Optional)

Please list any issues that are fixed by this PR in the format #<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.

Examples/Screenshots (Optional)

Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.

Use this table template to show examples of your changes:

Before After
Content Cell Content Cell
Content Cell Content Cell

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely break Relay metrics so give on-call a heads-up
Relay metrics will then needs to set the default dimension

@heilhead heilhead merged commit 75a7761 into v2.0 Jan 26, 2024
10 of 11 checks passed
@ganchoradkov ganchoradkov mentioned this pull request Feb 6, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants