Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds session_request_expire & proposal_expire to w3w #4180

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 26, 2024

Description

Introduced two new events to Web3Wallet

  • session_request_expire
  • proposal_expire

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Jan 26, 2024
@ganchoradkov ganchoradkov marked this pull request as ready for review January 29, 2024 10:03
@ganchoradkov ganchoradkov merged commit 20c2985 into v2.0 Feb 1, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the feat/w3wallet-events branch February 1, 2024 13:00
@ganchoradkov ganchoradkov mentioned this pull request Feb 6, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants