Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds session_authenticate to expirer #4420

Merged
merged 3 commits into from
Apr 19, 2024
Merged

fix: adds session_authenticate to expirer #4420

merged 3 commits into from
Apr 19, 2024

Conversation

ganchoradkov
Copy link
Member

Description

  • Added session_authenticate requests to expirer
  • Updated execution order to first set items in expirer and then saving to store
  • Updated tests

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@arein arein added the accepted label Apr 8, 2024
@ganchoradkov ganchoradkov self-assigned this Apr 8, 2024
@bkrem bkrem changed the title feat: adds session_authenticate to expirer fix: adds session_authenticate to expirer Apr 11, 2024
bkrem
bkrem approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pinning the expected behaviour with the tests 💯

packages/sign-client/src/controllers/engine.ts Outdated Show resolved Hide resolved
packages/sign-client/src/controllers/engine.ts Show resolved Hide resolved
packages/sign-client/src/controllers/engine.ts Show resolved Hide resolved
packages/types/src/sign-client/engine.ts Outdated Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit 6b68620 into v2.0 Apr 19, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the fix/set-item-in-expirer branch April 19, 2024 07:09
@ganchoradkov ganchoradkov mentioned this pull request May 8, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

@lukaisailovic lukaisailovic Awaiting requested review from lukaisailovic

Assignees

@ganchoradkov ganchoradkov

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganchoradkov @bkrem @arein