feat: disable request queue #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
April 15, 2024 12:07
|
seems like there's also a bug fix with |
I'm testing what might be causing the network drops |
added 18 commits
April 17, 2024 14:57
# Conflicts: # package-lock.json # packages/sign-client/package.json
# Conflicts: # packages/sign-client/src/controllers/engine.ts
devceline
reviewed
Apr 23, 2024
Comment on lines
+63
to
+65
| type SignConfig = { | ||
| disableRequestQueue?: boolean; | ||
| }; |
There was a problem hiding this comment.
nitpick, optional: shouldn't this be in types?
There was a problem hiding this comment.
what do you mean? It is in packages/types/src/sign-client/client.ts
bkrem
reviewed
Apr 23, 2024
added 2 commits
April 29, 2024 11:21
…/walletconnect-monorepo into feat/disable-request-queue
bkrem
approved these changes
May 2, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new init param
signConfigwith initialdisableRequestQueueparameter. This option allows wallets to disable the session request queue if they wish.Additionally, added a few improvements to connection handling because if several days long
socket hang upissues in CI such aspingtimers when connection is closed intentionallyType of change
How has this been tested?
tests
canary -
2.12.2-req-q.0Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.