Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set origin header in react native #146

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

ignaciosantise
Copy link
Contributor

@ignaciosantise ignaciosantise commented Nov 8, 2023

Summary

Overriding the origin header in the relay connection for RN.

Tested:

  • using a project id with empty allowed domains
  • using a project id with specified allowed domains

Relates to: WalletConnect/walletconnect-monorepo#3847

Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just one question around base case behaviour

jsonrpc/ws-connection/src/ws.ts Show resolved Hide resolved
@ignaciosantise ignaciosantise merged commit b00111d into master Nov 9, 2023
0 of 24 checks passed
@ignaciosantise ignaciosantise deleted the feat/mobile-origin branch November 9, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants