Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identity key storing optimistically #150

Merged
merged 21 commits into from
Nov 23, 2023
Merged

Fix identity key storing optimistically #150

merged 21 commits into from
Nov 23, 2023

Conversation

devceline
Copy link
Contributor

@devceline devceline commented Nov 23, 2023 •
edited
Loading

Changes

  • Refactor persist logic to defer persistence till after key server returns 200
  • Added check for signature validity (not empty)
  • Change access of identityKeys.identityKeys (the actual store) to be public
  • Add dev deps to allow successful testing on ci (fixex for circular dep)

Resolves #151

@devceline devceline changed the title Fix/identity key trust Fix identity key storing optimistically Nov 23, 2023
@devceline devceline requested a review from bkrem November 23, 2023 12:10
bkrem
bkrem approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, just some minor corrections needed 👍

Thanks for setting up a proper test suite here, much needed 💯

misc/identity-keys/package.json Outdated Show resolved Hide resolved
misc/identity-keys/test/identity-keys.test.ts Outdated Show resolved Hide resolved
misc/identity-keys/src/identity-keys.ts Outdated Show resolved Hide resolved
misc/identity-keys/src/identity-keys.ts Outdated Show resolved Hide resolved
misc/identity-keys/src/identity-keys.ts Outdated Show resolved Hide resolved
misc/identity-keys/src/identity-keys.ts Outdated Show resolved Hide resolved
misc/identity-keys/test/identity-keys.test.ts Outdated Show resolved Hide resolved
@devceline devceline merged commit 926e544 into master Nov 23, 2023
24 checks passed
@devceline devceline deleted the fix/identity-key-trust branch November 23, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IdentityKeys.registerIdentity persisting bad keys
2 participants
@devceline @bkrem