Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show copy link button when QR code is loaded #1575

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • fix: Wait till qr code is loaded to show copy link button

Associated Issues

closes #1443

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 15, 2023 11:44am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 15, 2023 11:44am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 15, 2023 11:44am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 15, 2023 11:44am

Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

Causes a layout shift but I think it's still good since we have layout animation;

Screen.Recording.2023-12-15.at.16.00.43.mov

@svenvoskamp
Copy link
Contributor Author

svenvoskamp commented Dec 15, 2023

LGTM ⚡️

Causes a layout shift but I think it's still good since we have layout animation;

Screen.Recording.2023-12-15.at.16.00.43.mov

Yes was aware of that, but I think it is not disruptive or anything

@svenvoskamp svenvoskamp merged commit 90e63a7 into V3 Dec 15, 2023
11 checks passed
@svenvoskamp svenvoskamp deleted the fix/copy-qr-code branch December 15, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Not clear link button is not clickable before QR loads
2 participants