fix: dayjs locale format seconds is not working and is polluting the global dayjs locale #1689

nikosrossolatos · 2024-01-01T12:15:56Z

Breaking Changes

N/A

Changes

fix: getRelativeDateFromNow will no longer return %s sec when seconds are provided.
- dayjs@1.11.10 is expecting "%d sec" instead of "%s sec" (here's why) to make the proper conversion to "10 sec"
fix: do not pollute the global en locale
- We found out this bug while using this library on our app. It shouldn't be affecting every app or library that uses this

vercel · 2024-01-01T12:16:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web3modal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 9:34am
web3modal-gallery	✅ Ready (Inspect)	Visit Preview		May 8, 2024 9:34am
web3modal-laboratory	✅ Ready (Inspect)	Visit Preview		May 8, 2024 9:34am
web3modal-react-wagmi-ex	✅ Ready (Inspect)	Visit Preview		May 8, 2024 9:34am
web3modal-vue-wagmi-ex	✅ Ready (Inspect)	Visit Preview		May 8, 2024 9:34am

vercel · 2024-01-01T12:16:03Z

@nikosrossolatos is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

packages/common/src/utils/DateUtil.ts

tomiir · 2024-01-17T20:02:17Z

The dayJS fix LGTM!
The namespace pollution fix looks ok, but copying @xzilja and @enesozturk to double check it doesn't have unwanted side-effects.

Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com>

enesozturk

LGTM

nikosrossolatos · 2024-02-07T17:17:34Z

LGTM

@enesozturk How can I run the vercel or the rest of the checks since I am missing authorisation so that we can merge this PR? :D

enesozturk · 2024-02-09T12:18:57Z

@nikosrossolatos seems interesting, I'll investigate this and let you know. The issues are not expected so it shouldn't be a problem for people outside of the team, it's something we should fix unless you touch the GH workflow code.

glitch-txs · 2024-02-09T12:52:06Z

Vercel ones need to be authorized. I authorized labs, if this is good we can just merge it

nikosrossolatos · 2024-02-12T10:43:34Z

Vercel ones need to be authorized. I authorized labs, if this is good we can just merge it

Yeap that's what it saying for me too 😅 missing authorisation. I'll leave this to you then to merge if it's okay

* chore(lab): dogfooding button (WalletConnect#2206) * chore: fix typos (WalletConnect#2188) Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * refactor: render tooltip in root (WalletConnect#2210) * feat: add react-ethers 6 example (WalletConnect#1920) Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> * refactor: swap business logic improvements (WalletConnect#2199) * chore: detailed canary timings (WalletConnect#2214) * chore: add apple app site association (WalletConnect#2216) * :feat add send logic (WalletConnect#2173) Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * fix: apple-app-site-association content type header (WalletConnect#2217) * feat: Sign 2.5 (WalletConnect#2033) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * feat: Smart Account 6492 Signature Tests (WalletConnect#2196) * fix: sign modal not appearing when going through siwe flow (WalletConnect#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (WalletConnect#2190) Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> * fix: missing call to SIWE `onSignOut` (WalletConnect#2054) Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (WalletConnect#1689) Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com> Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :deprecate - injected connector (WalletConnect#2223) * chore: more canary timings (WalletConnect#2215) * chore: updates ethereum-provider to latest (WalletConnect#2226) * fix: add assertion for the erc20 abi json import (WalletConnect#2225) * update packages --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Luka Isailovic <lukaisailovic@gmail.com> Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: GooxPF <gooxpf@gmail.com> Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> Co-authored-by: Tiến Nguyễn Khắc <tien.nguyenkhac@icloud.com> Co-authored-by: Nikos Rossolatos <nikos@cointracker.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com>

* chore(lab): dogfooding button (WalletConnect#2206) * chore: fix typos (WalletConnect#2188) Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * refactor: render tooltip in root (WalletConnect#2210) * feat: add react-ethers 6 example (WalletConnect#1920) Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> * refactor: swap business logic improvements (WalletConnect#2199) * chore: detailed canary timings (WalletConnect#2214) * chore: add apple app site association (WalletConnect#2216) * :feat add send logic (WalletConnect#2173) Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * fix: apple-app-site-association content type header (WalletConnect#2217) * feat: Sign 2.5 (WalletConnect#2033) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * feat: Smart Account 6492 Signature Tests (WalletConnect#2196) * fix: sign modal not appearing when going through siwe flow (WalletConnect#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (WalletConnect#2190) Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> * fix: missing call to SIWE `onSignOut` (WalletConnect#2054) Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (WalletConnect#1689) Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com> Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :deprecate - injected connector (WalletConnect#2223) * chore: more canary timings (WalletConnect#2215) * chore: updates ethereum-provider to latest (WalletConnect#2226) * fix: add assertion for the erc20 abi json import (WalletConnect#2225) * fix: encodes all `personal_sign` messages to hex (WalletConnect#2237) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> * fix: siwe tests for 1 click auth (WalletConnect#2267) * feat: phantom deeplink for mobile app browsers (WalletConnect#2250) Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: 4.2.0 bug fixes (WalletConnect#2234) Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> * chore: UI canary 10 minute timeout (WalletConnect#2269) * chore: bump to main 4.2.0 version (WalletConnect#2270) * :feat social login - 1 - UI (WalletConnect#2266) Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :feat social login - 2 - Wallet (WalletConnect#2272) * :feat social login - 3 - AuthConnector (WalletConnect#2274) * refactor: update profile name rendering logic (WalletConnect#2276) * :hotfix in app support for injected and announced wallets (WalletConnect#2279) * refactor/theme variables and v4 ui updates (WalletConnect#2277) --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Luka Isailovic <lukaisailovic@gmail.com> Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: GooxPF <gooxpf@gmail.com> Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> Co-authored-by: Tiến Nguyễn Khắc <tien.nguyenkhac@icloud.com> Co-authored-by: Nikos Rossolatos <nikos@cointracker.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com>

nikosrossolatos force-pushed the fix/dayjs-seconds branch from 081188a to 1d6d21d Compare January 1, 2024 12:16

nikosrossolatos commented Jan 1, 2024

View reviewed changes

packages/common/src/utils/DateUtil.ts Show resolved Hide resolved

nikosrossolatos force-pushed the fix/dayjs-seconds branch from 1d6d21d to d32ecda Compare January 1, 2024 12:18

fix: dayjs seconds format has bug and affects global packages

51f0a62

nikosrossolatos force-pushed the fix/dayjs-seconds branch from d32ecda to 51f0a62 Compare January 1, 2024 12:18

nikosrossolatos commented Jan 1, 2024

View reviewed changes

packages/common/src/utils/DateUtil.ts Show resolved Hide resolved

vercel bot deployed to Preview – web3modal-gallery January 1, 2024 12:20 View deployment

xzilja requested a review from enesozturk January 2, 2024 08:17

tomiir and others added 4 commits January 19, 2024 08:16

fix: lint issues. Ignore coverage in eslint (WalletConnect#1784)

aaa27cb

chore: bump to 3.5.7 (WalletConnect#1783)

beafcbd

feat: added native example wallets deeplinks (WalletConnect#1804)

c03424c

Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com>

Merge branch 'V3' into fix/dayjs-seconds

21137fe

vercel bot deployed to Preview – web3modal-gallery February 5, 2024 07:49 View deployment

enesozturk approved these changes Feb 5, 2024

View reviewed changes

vercel bot deployed to Preview – web3modal-laboratory February 7, 2024 17:49 View deployment

vercel bot deployed to Preview – web3modal-vue-wagmi-ex February 13, 2024 09:32 View deployment

vercel bot deployed to Preview – web3modal-react-wagmi-ex February 13, 2024 09:38 View deployment

enesozturk changed the base branch from V3 to V4 April 8, 2024 18:42

refactor: update dateutil tests

f9bfaf9

vercel bot deployed to Preview – web3modal-gallery April 8, 2024 19:08 View deployment

enesozturk added 2 commits April 8, 2024 22:10

Merge branch 'V4' into fix/dayjs-seconds

9de2760

chore: revert changes

d1ee9e0

tomiir approved these changes Apr 8, 2024

View reviewed changes

chore: update ui tests permissions

0209df9

vercel bot deployed to Preview – web3modal-gallery April 23, 2024 07:46 View deployment

enesozturk added 2 commits April 23, 2024 10:49

chore: override pr checks permissions

e46bb10

chore: add write permissions to ui tests

d0909e8

vercel bot deployed to Preview – web3modal-gallery April 23, 2024 07:55 View deployment

chore: revert workflow permission changes

a34d71f

vercel bot deployed to Preview – web3modal-gallery April 23, 2024 10:19 View deployment

Merge branch 'V4' into fix/dayjs-seconds

d65c757

vercel bot deployed to Preview – web3modal-gallery May 7, 2024 08:26 View deployment

vercel bot deployed to Preview – web3modal-demo May 7, 2024 08:28 View deployment

vercel bot deployed to Preview – web3modal-laboratory May 7, 2024 08:31 View deployment

Merge branch 'V4' into fix/dayjs-seconds

f31c38c

vercel bot deployed to Preview – web3modal-gallery May 7, 2024 10:29 View deployment

Merge branch 'V4' into fix/dayjs-seconds

f98db4c

vercel bot deployed to Preview – web3modal-gallery May 7, 2024 18:28 View deployment

Merge branch 'V4' into fix/dayjs-seconds

c24a6cb

vercel bot deployed to Preview – web3modal-gallery May 8, 2024 08:53 View deployment

chore: add permissions to the ui tests

cb3d575

vercel bot deployed to Preview – web3modal-gallery May 8, 2024 09:13 View deployment

vercel bot deployed to Preview – web3modal-demo May 8, 2024 09:14 View deployment

vercel bot deployed to Preview – web3modal-laboratory May 8, 2024 09:17 View deployment

fix: permissions

fcdb768

vercel bot deployed to Preview – web3modal-gallery May 8, 2024 09:29 View deployment

vercel bot deployed to Preview – web3modal-demo May 8, 2024 09:33 View deployment

vercel bot deployed to Preview – web3modal-laboratory May 8, 2024 09:34 View deployment

tomiir approved these changes May 8, 2024

View reviewed changes

tomiir merged commit 1066194 into WalletConnect:V4 May 8, 2024
10 of 11 checks passed

Jircs1 mentioned this pull request Jun 10, 2024

[Snyk] Upgrade @web3modal/wagmi from 4.1.11 to 4.2.1 Jircs1/web-examples#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: dayjs locale format seconds is not working and is polluting the global dayjs locale #1689

fix: dayjs locale format seconds is not working and is polluting the global dayjs locale #1689

nikosrossolatos commented Jan 1, 2024

vercel bot commented Jan 1, 2024 •

edited

Loading

vercel bot commented Jan 1, 2024

tomiir commented Jan 17, 2024

enesozturk left a comment

nikosrossolatos commented Feb 7, 2024

enesozturk commented Feb 9, 2024

glitch-txs commented Feb 9, 2024 •

edited

Loading

nikosrossolatos commented Feb 12, 2024

fix: dayjs locale format seconds is not working and is polluting the global dayjs locale #1689

fix: dayjs locale format seconds is not working and is polluting the global dayjs locale #1689

Conversation

nikosrossolatos commented Jan 1, 2024

Breaking Changes

Changes

vercel bot commented Jan 1, 2024 • edited Loading

vercel bot commented Jan 1, 2024

tomiir commented Jan 17, 2024

enesozturk left a comment

Choose a reason for hiding this comment

nikosrossolatos commented Feb 7, 2024

enesozturk commented Feb 9, 2024

glitch-txs commented Feb 9, 2024 • edited Loading

nikosrossolatos commented Feb 12, 2024

vercel bot commented Jan 1, 2024 •

edited

Loading

glitch-txs commented Feb 9, 2024 •

edited

Loading